[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5557 [Tor Bridge]: Tor helpers' launch error message contains useless whitespace

#5557: Tor helpers' launch error message contains useless whitespace
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Looks good.  A few things to fix up or add on review:

   * changes files should mention bug numbers
   * The hex-number-formatting function should probably get extracted and
 get a couple of unit tests of its own.
   * We still write our if (...)s without internal spaces inside the
 parenthesis.
   * Does this break badly if sizeof(int) > 4, and we ever get a huge
 errno?  If so we should check for values more or less than INT32_MIN and
 INT32_MAX.

 Up to you if you want to fix these or if you'd rather I do it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5557#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs