Re: [tor-bugs] #6205 [Stem]: integration tests fail on Windows

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#6205: integration tests fail on Windows
----------------------+-----------------------------------------------------
 Reporter:  reganeet  |          Owner:  reganeet         
     Type:  defect    |         Status:  needs_information
 Priority:  normal    |      Milestone:                   
Component:  Stem      |        Version:                   
 Keywords:            |         Parent:                   
   Points:            |   Actualpoints:                   
----------------------+-----------------------------------------------------
Changes (by atagar):

  * status:  needs_review => needs_information


Comment:

 Looks great! Only a couple questions...

 1. stem/util/system.py expand_path - Don't we need the drive letters for a
 path to be absolute? That was the bit that I suspected would be difficult,
 though if it's not necessary then great.

 2. test/integ/util/system.py - Why are you skipping these tests if the
 pgrep lookup fails? It's just checking if there are multiple tor
 instances, which we could probably default to 'False'.

 Cheers! -Damian

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6205#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs