Re: [tor-bugs] #6205 [Stem]: integration tests fail on Windows

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#6205: integration tests fail on Windows
----------------------+-----------------------------------------------------
 Reporter:  reganeet  |          Owner:  reganeet      
     Type:  defect    |         Status:  needs_revision
 Priority:  normal    |      Milestone:                
Component:  Stem      |        Version:                
 Keywords:            |         Parent:                
   Points:            |   Actualpoints:                
----------------------+-----------------------------------------------------
Changes (by atagar):

  * status:  needs_information => needs_revision


Comment:

 > Yes we do; os.getcwd() will provide an absolute path with the drive
 letter.

 Ahh, gotcha.

 > Can we set the default value of "is_extra_tor_running" to False, get rid
 of "if self.is_extra_tor_running is None" in setUp()

 Simplest is probably just to have an 'is_windows()' check and hardcode it
 to False in that case. It would be nice if we could later check this on
 Windows, but not at all vital.

 Pushed your changes with some minor tweaks...
 https://gitweb.torproject.org/stem.git/commitdiff/6f626f3

 Would you mind exercising these new Windows expand_path() use cases in the
 unit tests? If you look in 'test/unit/util/system.py' you'll find a
 'test_expand_path_unix' test. It would be great to have a windows
 counterpart for this. :)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6205#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs