[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5557 [Tor Bridge]: Tor helpers' launch error message contains useless whitespace

#5557: Tor helpers' launch error message contains useless whitespace
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Better!  Here are a couple of changes I'll  make before merging:

 In format_hex_number_for_helper_exit_status:
     * The else clause isn't how we usually write them.
     * The function should either nul-terminate its output, or warn loudly
 in its output that it doesn't NUL-terminate its output.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5557#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs