Re: [tor-bugs] #6234 [Stem]: stem.socket.ControlSocket.is_alive() should check if socket is open explicitly

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#6234: stem.socket.ControlSocket.is_alive() should check if socket is open
explicitly
------------------------+---------------------------------------------------
    Reporter:  gsathya  |       Owner:  atagar  
        Type:  defect   |      Status:  reopened
    Priority:  normal   |   Milestone:          
   Component:  Stem     |     Version:          
  Resolution:           |    Keywords:          
      Parent:           |      Points:          
Actualpoints:           |  
------------------------+---------------------------------------------------
Changes (by gsathya):

  * status:  closed => reopened
  * resolution:  not a bug =>


Comment:

 The is_alive() method is broken when a controller issues a "QUIT" message.

 {{{
 >> controller.msg("QUIT")
 closing connection
 >> controller._socket.is_alive()
 True #Should be False
 }}}

 Do we want this to happen? Maybe we can use _is_alive() for internal
 purposes which uses __is_alive boolean and another is_alive() which
 actually checks the socket with a query and expose this as the end-user
 API? We can use a sample PROTOCOLINFO query to check - it doesn't need
 auth, so it won't close the connection

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6234#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs