[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6114 [Stem]: Implement GETCONF parsing in Stem
#6114: Implement GETCONF parsing in Stem
--------------------+-------------------------------------------------------
Reporter: neena | Owner: neena
Type: task | Status: needs_review
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: | Parent:
Points: | Actualpoints:
--------------------+-------------------------------------------------------
Changes (by neena):
* status: needs_revision => needs_review
Comment:
Replying to [comment:10 atagar]:
> > + :param bool multiple: if True, the value(s) provided are lists of
all returned values,
> > + otherwise this just provides the first
value
>
> Sounds good, but lets have the get_conf() handle the 'multiple' flag.
There's really little need for this to influence how we parse the
response.
done.
> I would suggest that we add two methods to the controller...
>
> 2. get_conf_map with parameters...
> - param (str or list for batch call)
> - default (object)
> }}}
Not sure why you didn't add a 'multiple' there. Did you want it to default
to multiple, or mixed (string or list of strings)?
(I added a multiple parameter)
> > Ah. I've removed this check entirely. Were you suggesting something
else?
> On reflection, the check is appropriate for the first of those two
methods.
Added, to both of the methods. It checks as long as none of the requested
values were weird, i.e., needed to be retrieved by querying for a
different value.
> > I'm thinking it would be better to this if/when we have a hidden
service target?
> Are hidden service options something that we can setconf to enable, test
against, then resetconf to revert them? If not, then maybe we should add a
RUN_HIDDEN_SERVICE target for the integ tests.
>
> HiddenServiceOptions is a weird use case so we really should include it
in both our integ and unit tests.
I have added these tests in my
[http://repo.or.cz/w/stem/neena.git/shortlog/refs/heads/setconf-wrapper
setconf-wrapper branch].
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6114#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs