Re: [tor-bugs] #3594 [Tor Bridge]: Add support for SOCKS parameters in Bridge and {Client, Server}TransportPlugin lines

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3594: Add support for SOCKS parameters in Bridge and
{Client,Server}TransportPlugin lines
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 More stuff:
    * tor_escape_string() wants a different name.
    * Looks like tor_escape_string() can't handle \0s.  Did we care about
 that? It's not documented really.
    * The comment "/** test for tor_escape_string() */" looks misplaced.
    * What's with all the strcpys in test_util_string_is_key_value? Can't
 string_is_key_value take them directly?
    * Why should Socks5ProxyUsername be mutually exclusive with Socks5Proxy
 and Socks5ProxyPassword?  (In options_validate.)  That seems wrong.  Those
 options would be more r less meaningless without each other, I think.
    * re get_socks_arg_by_bridge_addrport: I don't like proliferating
 functions that look up an object and return a subfield of the object.  I
 would rather have one set of functions that returns a bridge_info_t, and
 have the caller extract the subfield or call another function to do so.
 That way, if we want to look up bridges M ways and get N of their fields
 after the lookup, we only have M+N functions rather than potentially M*N.
    * Please don't use strcpy ever.
    * Please don't move around functions except in commits that do nothing
 besides moving functions.
    * That "null_pass" business is goofy; you can just say pass = "",
 right?

 No changes file.

 Doesn't pass make check-spaces.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3594#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs