[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6249 [Vidalia]: Show amount of traffic in connections list in Network Map window.
#6249: Show amount of traffic in connections list in Network Map window.
-------------------------+--------------------------------------------------
Reporter: cypherpunks | Owner: chiiph
Type: enhancement | Status: needs_revision
Priority: minor | Milestone:
Component: Vidalia | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by cypherpunks):
>Why have you chosen to make the change in the if condition in Stream.cpp?
I explained up above. The old condition was always false.
>Should be:
>{{{if (msg.size() > 3) {}}}
Oops, yeah.
>In StreamItem.cpp, the _bytesReceived and _bytesSent initialization
should be done as a part of the constructor init list.
>Methods bytesReceived() and bytesSent() should be const.
Yup, yup. (Too much Java for me!) I attached a new patch.
I also decided against this line, because the B and KB are so easily
confused at a glance on the short-lived connections:
{{{if (bytes < 1 * K) return QString("%1 B").arg(bytes);}}}
>You should upload a format-patch or a branch in some public git repo that
I can merge, so you get credit for this patch.
Haven't a clue how to do that and can't be bothered! :) You seem to know
what you're doing. If you like it can you just patch it in somehow? I
don't care about attribution. Public domain. Y'all can have it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6249#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs