[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9108 [Tor]: Make circuitbuild.c: global_circuitlist a proper doubly-linked list

#9108: Make circuitbuild.c: global_circuitlist a proper doubly-linked list
-------------------------+--------------------------------------------------
 Reporter:  marek        |          Owner:                  
     Type:  enhancement  |         Status:  needs_review    
 Priority:  minor        |      Milestone:  Tor: unspecified
Component:  Tor          |        Version:                  
 Keywords:               |         Parent:                  
   Points:               |   Actualpoints:                  
-------------------------+--------------------------------------------------

Comment(by nickm):

 I think this is a good idea.  I'm was confused by moving the remove code
 into circuit_free, but I think it does make sense there.  We should audit
 every caller to circuit_free, of course.  I was also worried about not
 using FOREACH_SAFE for the loop that has a local variable called "victim",
 but apparently that "victim" is only at risk of being marked, not freed.
 I should double-check this all more carefully rsn.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9108#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs