[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #9163 [Tor]: Remove PT SOCKS argument length limit when SOCKS4 is used
#9163: Remove PT SOCKS argument length limit when SOCKS4 is used
---------------------------+------------------------------------------------
Reporter: asn | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Tor: 0.2.5.x-final
Component: Tor | Version:
Keywords: tor-client pt | Parent:
Points: | Actualpoints:
---------------------------+------------------------------------------------
Repeating from comment:31:ticket:3594:
{{{
After reading #7153 and looking at
faf4f6c6d1da54b0a6b0c9946112f2e448867a8f, I see that in
validate_transport_socks_arguments() I reject SOCKS arguments larger than
MAX_SOCKS5_AUTH_SIZE_TOTAL even if I don't know the SOCKS version that the
pluggable transport proxy is going to use. Maybe this check shouldn't
happen in validate_transport_socks_arguments() so that we allow large
SOCKS arguments if SOCKS4a is used.
}}}
Yawning Angel experienced this limit while coding his/her SSH pluggable
transport:
https://lists.torproject.org/pipermail/tor-dev/2013-June/005083.html
Unfortunately, this is not trivial to fix because when
`validate_transport_socks_arguments()` is called we still don't know which
SOCKS version the transport proxy supports.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9163>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs