[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #11183 [meek]: Make an HTTP requestor Firefox extension for meek-client
#11183: Make an HTTP requestor Firefox extension for meek-client
-------------------------+--------------------
Reporter: dcf | Owner: dcf
Type: project | Status: closed
Priority: normal | Milestone:
Component: meek | Version:
Resolution: fixed | Keywords: meek
Actual Points: | Parent ID: #10935
Points: |
-------------------------+--------------------
Comment (by gk):
Replying to [comment:22 dcf]:
> Replying to [comment:20 gk]:
> > I have to think a bit about your usage of nsISocketTransport and
whether you are affected by the things we ran into in #9531. See the
comments there (e.g. regarding OPEN_BLOCKING|OPEN_UNBUFFERED)
>
> Okay. I don't know what to make of that.
Sorry for the delay. Here comes the second part of the code review for
https://gitweb.torproject.org/pluggable-
transports/meek.git/blob/HEAD:/firefox/components/main.js. Basically, it
looks good to me. Nice work! One nit is the trailing comma after
{{{
status: context.responseStatus
}}}
but that may be deliberate again (what is the rationale for this, btw?).
Then I was wondering about the length limit especially that of the
response. What is the reasoning behind it? Doesn't that prohibit certain
use cases like retrieving PDF files larger than 1000000 Bytes?
And, finally, there is no option to get OPEN_BLOCKING and OPEN_UNBUFFERED
(see https://mxr.mozilla.org/mozilla-
esr24/source/netwerk/base/src/nsSocketTransport2.cpp#1755) and the Necko
folks won't implement that.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11183#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs