Re: [tor-bugs] #8746 [Tor]: Tor tries to kill nonexistent proxy PID on second SIGINT

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#8746: Tor tries to kill nonexistent proxy PID on second SIGINT
-------------------------+-------------------------------------------------
     Reporter:  dcf      |      Owner:  nickm
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-client, pt, 024-deferrable,
Actual Points:           |  025-triaged
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by andrea):

 Review of bug8746_v2:

 6b33a9b26a90b3ee684b78024dd436024dde9297:
  - Shouldn't set_waitpid_callback() tor_free(old_ent) if it's non-NULL?
  - Otherwise, I think this is all okay

 38b9983d9bee2023533cb109adaec98148f48fb4:
  - I think this all looks fine

 4ace54466b034db9cea29e909c5b2ee552053719:
  - Looks good to me

 e93fd974e1f5593fbaa782b8f43ebe161cfec091:
  - Looks good to me

 c76d615fcd0cbf9cee88ea687724b5deae68ff80:
  - Awwww, no functinos?  Don't tell me you're against sfunctions too.

 76da16a15f5d0cc0c1f0ccb8ec3a310d50b43fe2:
  - Looks good to me

 da598b74701aba5efdc97029c05b17c850bb7d46:
  - Looks good to me

 0017a8668785dfa3715748155b9fdb35bb671cf3:
  - This is just the changes file; looks fine to me

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8746#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs