[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #12404 [Tor]: #9777 breaks clients that build with disabled curve25519
#12404: #9777 breaks clients that build with disabled curve25519
------------------------+-------------------------------------
Reporter: arma | Owner: nickm
Type: defect | Status: needs_information
Priority: normal | Milestone: Tor: 0.2.5.x-final
Component: Tor | Version:
Resolution: | Keywords: tor-client 024-backport
Actual Points: | Parent ID:
Points: |
------------------------+-------------------------------------
Changes (by nickm):
* status: assigned => needs_information
Comment:
Hang on. Isn't this already handled in onion_populate_cpath() with the "!
using_ntor" case in:
{{{
/* This circuit doesn't need/shouldn't be forced to have an ntor hop
*/
if (circ->build_state->desired_path_len <= 1 || ! using_ntor)
return 0;
}}}
I just tried building the maint-0.2.4 branch with --disable-curve25519 :
everything worked okay, and it built circuits just fine. I also verified
to see that it works with --enable-curve25519 and "UseNTorHandshake 0".
Then I tried the same cases on master, and that worked too.
Did anybody check to see if this bug was actually happening? I think we
can close it as "worksforme", unless you think we should retroactively
clarify the changelog.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12404#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs