[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12207 [Tor]: Improve unittest coverage of entrynodes.c



#12207: Improve unittest coverage of entrynodes.c
------------------------+----------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  needs_revision
     Priority:  normal  |  Milestone:
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client tor-guard
Actual Points:          |  Parent ID:
       Points:          |
------------------------+----------------------------------
Changes (by asn):

 * status:  new => needs_revision


Comment:

 Hm, I think I know a nicer way to solve the problem with that check. I can
 make that check a function (`bool is_router_descriptor_too_old(router)` or
 something), and then in the unittests I can mock it to be a NOP.


 Also, it seems like I forgot a hardcoded local path I used while writing
 the unittests. I will fix that soon too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12207#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs