Re: [tor-bugs] #15760 [Tor]: tortls.c fails to compile with OpenSSL 1.1.0-dev

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#15760: tortls.c fails to compile with OpenSSL 1.1.0-dev
------------------------+-------------------------------------------
     Reporter:  yancm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:  Tor: 0.2.7
   Resolution:          |   Keywords:  openssl, tor-tls 026-backport
Actual Points:          |  Parent ID:  #9476
       Points:          |
------------------------+-------------------------------------------

Comment (by yawning):

 NACK `1651dd57154a4375e7338a5022ee46b93611bf62`

 {{{
 + const size_t server_random_len = SSL_get_server_random(ssl, NULL, -1);
 + const size_t client_random_len = SSL_get_client_random(ssl, NULL, -1);
 + const size_t master_key_len = SSL_SESSION_get_master_key(session, NULL,
 -1);
 }}}

 The `len` parameter to each of those is a `size_t` now, all of those
 should pass in `0` as the 3rd argument, rest looks ok upon casual
 inspection.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15760#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs