[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16268 [Tor Browser]: non-en-US Tor Browser bundles still contain Firefox logo and "Firefox ESR" on about-Tor Browser-window
#16268: non-en-US Tor Browser bundles still contain Firefox logo and "Firefox ESR"
on about-Tor Browser-window
-------------------------+-------------------------------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Tor | Version:
Browser | Keywords: tbb-branding, TorBrowserTeam201506R
Resolution: | Parent ID:
Actual Points: |
Points: |
-------------------------+-------------------------------------------------
Changes (by mcs):
* cc: brade, mcs (added)
* keywords: tbb-branding => tbb-branding, TorBrowserTeam201506R
* status: new => needs_review
Comment:
Here is a fix for review:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug16268-01&id=30fa621c363a3b4645321f7770e60376d9bb3505
Kathy and I rewrote part of import-translations.sh to check for missing
.dtd and .properties files. We also inverted the locale and file loops
because we think that makes sense now that we have 8 .dtd and .properties
files. But let us know if you'd prefer a simpler set of changes to
import-translations.sh.
One related concern: when we run the revised import-translations.sh
script, we end up with undesirable & entities in the aboutDialog.dtd
files, e.g.,
{{{
<!ENTITY project.start "&brandShortName; is developed by ">
}}}
I know we encountered this before wih Torbutton and/or Tor Launcher, but I
do not remember how we fixed it. Maybe there was some Transifex magic
involved?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16268#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs