[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16317 [Nyx]: Minor setup.py issues.

#16317: Minor setup.py issues.
-------------------------+--------------------------------
     Reporter:  yawning  |      Owner:  atagar
         Type:  defect   |     Status:  closed
     Priority:  normal   |  Milestone:
    Component:  Nyx      |    Version:
   Resolution:  fixed    |   Keywords:  installation, easy
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------
Changes (by atagar):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Thanks Yawning! Made some adjustments to make our setup.py more intuitive.

 You were absolutely right that we should adjust our shebang line.
 Distutils usually does this for us, so added a bit akin to what it does.

 As for your second point, we have a couple arguments to our installer for
 additional resources...

   * --man-page to specify the man page location
   * --sample-path to specify the nyxrc.sample location

 You're right that it's confusing that those don't respect --user or
 --prefix. This is actually normal for distutils (I was confused too that
 absolute resource paths aren't adjusted). That said, it *is* odd so
 changed our setup.py to not install those by default.

 Feel free to reopen if you can think of anything else!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16317#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs