[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16355 [Torsocks]: [PATCH] Add usleep to data_impl functions

#16355: [PATCH] Add usleep to data_impl functions
-----------------------------+-------------------------------------
     Reporter:  cypherpunks  |      Owner:  dgoulet
         Type:  enhancement  |     Status:  new
     Priority:  trivial      |  Milestone:
    Component:  Torsocks     |    Version:
   Resolution:               |   Keywords:  torsocks cpu spike hang
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------

Comment (by yawning):

 NACK.  IMO the code should just use blocking I/O here, saving/restoring
 O_NONBLOCK before/after doing the socks handshake (using select or poll
 would also be less kludgy).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16355#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs