[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16181 [Tor Browser]: OS X bundling in Gitian is broken with ESR 38

#16181: OS X bundling in Gitian is broken with ESR 38
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  gk
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  tbb-gitian, ff38-esr,
   Resolution:           |  tbb-5.0a3-essential, TorBrowserTeam201506
Actual Points:           |  Parent ID:  #15772
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:9 mcs]:
 > Replying to [comment:8 gk]:
 > > I am not sure about that. I compared the `precomplete` file in
 TorBrowser.app/Contents/Resources with the one found in a default
 Firefox.app and it looked sane. The one we create and put into
 TorBrowser.app/ looks sane to me as well (I attached it). What did you
 have in mind?
 >
 > I am saying there should only be one precomplete file (the one we
 create) and it should be under TorBrowser.app/Contents/Resources/

 Sorry, I should have read the bug you linked to earlier (so much about my
 awesomeness ;) ). Attached is an updated patch that should address all the
 issues found by you, Kathy and me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16181#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs