[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14135 [Pluggable transport]: Incorrect SocksListener temporary error check

#14135: Incorrect SocksListener temporary error check
-------------------------------------+--------------------------
     Reporter:  adam-p               |      Owner:  dcf
         Type:  defect               |     Status:  needs_review
     Priority:  minor                |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  goptlib
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+--------------------------

Comment (by dcf):

 I added tests (currently failing) for the behavior we want:
 https://gitweb.torproject.org/pluggable-
 transports/goptlib.git/commit/?id=2a2a9b7cbff0dc9ff452a39a4199cec264e76dfe
 That is, an error that happens after calling Accept must be either 1) not
 reported, or 2) a Temporary net.Error. The patch in comment:5 makes the
 test pass.

 I know the SOCKS 4a code is old and busted, but if I let this patch depend
 on the one for SOCKS 5, then they are both going to get more delayed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14135#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs