[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19348 [Applications/Tor Browser]: Windows %BUILD_TARGET% changed in Tor Browser 6.0
#19348: Windows %BUILD_TARGET% changed in Tor Browser 6.0
--------------------------------------+-----------------------
Reporter: boklm | Owner: boklm
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-6.0-issues | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+-----------------------
Comment (by mcs):
Kathy and I should have noticed this when we tested the 6.x updater, but
the .htaccess file on our test server uses patterns like `^WINNT_x86
-.*/[^/]+/en-US`, so we just got lucky that our tests worked (and unlucky
that we did not notice the -x64 part).
After some detective work we found the culprit:
https://hg.mozilla.org/mozilla-central/rev/2a1163cd7736
Mozilla added the -64 to allow them to update people from 32-bit Firefox
to 64-bit Firefox (although as far as I know they have not done that yet).
I think someone with an old CPU might generate requests that include
WINNT_x86-gcc3-x86, so we should allow for that too.
Do we already leak the processor architecture? If the answer is "yes" we
may want to just keep this as-is. If not, we should patch the ABI getter
inside toolkit/modules/UpdateUtils.jsm (where the code now lives) to omit
the gWinCPUArch part.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19348#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs