[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22640 [Metrics/metrics-lib]: Change encoding of microdescriptor digests in network status entries from hex to base64
#22640: Change encoding of microdescriptor digests in network status entries from
hex to base64
---------------------------------+-----------------------------------
Reporter: karsten | Owner: metrics-team
Type: defect | Status: needs_review
Priority: Medium | Milestone: metrics-lib 1.9.0
Component: Metrics/metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------+-----------------------------------
Comment (by iwakeh):
The test and fix look fine. All checks and tests pass.
I would prefer to change the name `parseTwentyByteBase64String` into
`verifyTwentyByteBase64String` b/c most `parse*` methods return the valid
and sometimes changed data item (e.g. string to port int). Maybe turn
this into a general rule `verify*` for checking, `convert*` for explicit
changes, and `parse*` for the returned correct data item? (This could be
added in `ParseHelper`s javadoc or other comment on class level.)
Merge ready and fine for release 1.9.0
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22640#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs