[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17903 [Core Tor/Tor]: router_pick_trusteddirserver_impl should distinguish between fallbacks and authorities

#17903: router_pick_trusteddirserver_impl should distinguish between fallbacks and
authorities
-----------------------------+------------------------------------
 Reporter:  teor             |          Owner:  attila
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Very Low         |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Minor            |     Resolution:
 Keywords:  review-group-18  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  nickm            |        Sponsor:
-----------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Eek, the attached patch is way too heavy on the macro side. I feel like
 the resulting code is much harder to read/review even tho there is less
 code dup.

 Let's try to come up with a solution here that uses functions. It's far
 from trivial but I don't think it's impossible, and it will result in more
 maintainable code IMO.

 Moving this to `needs_revision` for now, but feel free to switch it back
 if you disagree with my evaluation.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17903#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs