[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20119 [Core Tor/Tor]: Fails to create the pid file when an enclosing directory is missing

Subject: Re: [tor-bugs] #20119 [Core Tor/Tor]: Fails to create the pid file when an enclosing directory is missing
From: "Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>
Date: Tue, 27 Jun 2017 01:24:26 -0000
Auto-submitted: auto-generated
Delivered-to: archiver@xxxxxxxx
Delivery-date: Mon, 26 Jun 2017 21:24:37 -0400
In-reply-to: <051.01b8c5d34a02c0b0306938d3722f8413@torproject.org>
List-archive: <http://lists.torproject.org/pipermail/tor-bugs/>
List-help: <mailto:tor-bugs-request@lists.torproject.org?subject=help>
List-id: "auto: Tor bug tracker status mails" <tor-bugs.lists.torproject.org>
List-post: <mailto:tor-bugs@lists.torproject.org>
List-subscribe: <https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs>, <mailto:tor-bugs-request@lists.torproject.org?subject=subscribe>
List-unsubscribe: <https://lists.torproject.org/cgi-bin/mailman/options/tor-bugs>, <mailto:tor-bugs-request@lists.torproject.org?subject=unsubscribe>
References: <051.01b8c5d34a02c0b0306938d3722f8413@torproject.org>
Reply-to: no-reply@xxxxxxxxxxxxxx, tor-assistants@xxxxxxxxxxxxxx
Sender: "tor-bugs" <tor-bugs-bounces@xxxxxxxxxxxxxxxxxxxx>

#20119: Fails to create the pid file when an enclosing directory is missing
----------------------------------+----------------------------------
 Reporter:  yurivict271           |          Owner:
     Type:  defect                |         Status:  new
 Priority:  Medium                |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor          |        Version:  Tor: 0.2.8.7
 Severity:  Normal                |     Resolution:
 Keywords:  triaged-out-20170308  |  Actual Points:
Parent ID:                        |         Points:  .5
 Reviewer:                        |        Sponsor:
----------------------------------+----------------------------------

Comment (by arma):

 This one is safe to treat orthogonally to the mess in #22731, since the
 write_pidfile() function in options_act() happens after the
 finish_daemon() call.

 Shouldn't we be using check_private_dir() for the place where we're going
 to put our PidFile? And then we could pass it the CPD_CREATE flag?

 Then if write_pidfile() fails, we should error out.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20119#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs