[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22717 [Core Tor/Tor]: Rename channelpadding.c's CHANNEL_IS_CLIENT to avoid confusion

#22717: Rename channelpadding.c's CHANNEL_IS_CLIENT to avoid confusion
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  technical-debt, disaster-waiting-    |  Actual Points:
  to-happen, 031-deferrable                      |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 I ran into a bunch of cases where channel->is_client flag was not updated,
 was incorrect, or disagreed with the definition I needed (in cases like
 bridges). How are we on ensuring that flag always has the same meaning as
 the macro checks for?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22717#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs