[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22762 [Core Tor/Tor]: Revise coding standards expectation for tests to be run before review

#22762: Revise coding standards expectation for tests to be run before review
---------------------------+------------------------------------
 Reporter:  chelseakomlo   |          Owner:  chelseakomlo
     Type:  task           |         Status:  merge_ready
 Priority:  Medium         |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |        Version:  Tor: unspecified
 Severity:  Normal         |     Resolution:
 Keywords:  documentation  |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:  catalyst       |        Sponsor:
---------------------------+------------------------------------

Comment (by chelseakomlo):

 Replying to [comment:4 cypherpunks]:
 > Running `make check` is redundant when you ask contributors to also run
 `make distcheck`. The later runs `make check` as one of its steps (see
 https://www.gnu.org/software/automake/manual/automake.html#Checking-the-
 Distribution).

 Cool, that is a great point, thanks for the feedback.

 catalyst, what do you think about just requiring `make distcheck`, with a
 brief explanation that this task runs both the test suite and checks the
 distribution?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22762#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs