[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17857 [Core Tor/Tor]: Create a consensus param to disable (netflow) padding if RSOS is enabled
#17857: Create a consensus param to disable (netflow) padding if RSOS is enabled
----------------------------------+------------------------------------
Reporter: teor | Owner: mikeperry
Type: enhancement | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, single-onion | Actual Points:
Parent ID: | Points: 1
Reviewer: | Sponsor:
----------------------------------+------------------------------------
Comment (by dgoulet):
Quick look at this (because it is relevant for prop224), this if condition
is kind of *mad* ;). Can we put it in a function (or extract some of it)
or at least break it down with more semantic? Anything that takes a while
to parse and understand the flow of the condition is imo error prone
overtime.
{{{
+ if (!get_options()->ConnectionPadding ||
+ (get_options()->Tor2webMode &&
+ !networkstatus_get_param(NULL,
+ CHANNELPADDING_TOR2WEB_PARAM,
+ CHANNELPADDING_TOR2WEB_DEFAULT, 0, 1))
+ || (rend_service_allow_non_anonymous_connection(get_options()) &&
+ !networkstatus_get_param(NULL,
+ CHANNELPADDING_SOS_PARAM,
+ CHANNELPADDING_SOS_DEFAULT, 0, 1))) {
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17857#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs