[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on large relays

#24104: Delay descriptor bandwidth reporting on large relays
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  034-backport-maybe, 033-backport-    |  Actual Points:
  maybe, 032-backport-maybe, 031-backport-       |
  maybe, 029-backport-maybe, security-low,       |
  guard-discovery-stats, chutney-wants, bwauth-  |
  wants, 034-triage-20180328,                    |
  034-removed-20180328, tor-bwauth               |
Parent ID:  #25925                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:17 juga]:
 > See my branch `ticket20104`.

 I will review it on GitHub.

 Please base the branch on 0.2.9, we might want to backport it like #23856.

 > `test_router.c` only contains 1 test and adding a test for this does not
 seem possible without adding more mocking functions, as `get_uptime` and
 `bandwidthcapacity`

 I think it's worth the extra time,

 > Should we also change the dir-spec line
 https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n354 to say
 something like:
 >
 > `- Its uptime is less than 24h and bandwidth has changed...`

 Yes, but we also need to say that old Tor versions ignored uptime. Please
 open a child ticket for the dir-spec change.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24104#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs