[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26326 [Applications/Tor Browser]: wine error when building Firefox ESR60 Windows x86_64

#26326: wine error when building Firefox ESR60 Windows x86_64
--------------------------------------------+--------------------------
 Reporter:  sukhbir                         |          Owner:  tbb-team
     Type:  defect                          |         Status:  new
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806  |  Actual Points:
Parent ID:  #26203                          |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------

Comment (by sukhbir):

 I am now building on top of `tor-browser-60.0.1esr-8.0-1` with tjr's and
 `fxc2` patches. Here is what my `mozconfig` looks like:

 {{{
 diff --git a/projects/firefox/mozconfig-windows-x86_64 b/projects/firefox
 /mozconfig-windows-x86_64
 index 669c124..7ae803c 100644
 --- a/projects/firefox/mozconfig-windows-x86_64
 +++ b/projects/firefox/mozconfig-windows-x86_64
 @@ -20,10 +20,12 @@ ac_add_options --enable-verify-mar

  # We can't build the sandbox code with mingw-w64:
  # https://bugzilla.mozilla.org/show_bug.cgi?id=1042426
 -ac_add_options --disable-sandbox
 +#ac_add_options --disable-sandbox
  # Let's make sure no preference is enabling either Adobe's or Google's
 CDM.
  ac_add_options --disable-eme
  ac_add_options --disable-crashreporter
  ac_add_options --disable-maintenance-service
  ac_add_options --disable-webrtc
 +ac_add_options --disable-stylo
  ac_add_options --disable-tests
 +ac_add_options --disable-accessibility
 }}}

 Two errors:

 (1):

 {{{
  4:18.25 /var/tmp/build/firefox-
 dd0fed4bd34c/security/certverifier/Buffer.cpp: In function 'bool
 mozilla::operator==(const Buffer&, const Buffer&)':
  4:18.25 /var/tmp/build/firefox-
 dd0fed4bd34c/security/certverifier/Buffer.cpp:15:73: error: 'memcmp' was
 not declared in this scope
  4:18.25      (a.length() == b.length() && memcmp(a.begin(), b.begin(),
 a.length()) == 0);
 }}}

 Simple fix for this (did anyone else get this? I wonder why not...):

 {{{
 diff --git a/security/certverifier/Buffer.cpp
 b/security/certverifier/Buffer.cpp
 index a36bfeabc13f..407d45a41253 100644
 --- a/security/certverifier/Buffer.cpp
 +++ b/security/certverifier/Buffer.cpp
 @@ -5,6 +5,7 @@
   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

  #include "Buffer.h"
 +#include <cstring>

  namespace mozilla {
 }}}

 (2):

 {{{
 22:11.45 update.locale
 22:13.80 cp: cannot stat 'instgen/helper.exe': No such file or directory
 22:13.80 /var/tmp/build/firefox-
 dd0fed4bd34c/toolkit/mozapps/installer/windows/nsis/makensis.mk:99: recipe
 for target 'uninstaller' failed
 }}}

 I am guessing this is #26205.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26326#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs