[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

#25787: geoip_load_file() tests don't work on all window build environments
---------------------------------------------+-----------------------------
 Reporter:  nickm                            |          Owner:  nickm
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.3.4.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  034-must regression tests win32  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by nickm):

 * cc: juga (added)
 * status:  accepted => needs_review


Comment:

 Please see branch `bug25787` with PR at
 https://github.com/torproject/tor/pull/143 .

 The fix here IMO is to just cut the Gordian Knot and generate the files we
 need ourself rather than trying at build-time to generate paths that
 Windows tests at run-time will accept.

 cc'ing juga because juga has seen these tests since the beginning, and
 ought to see it when we admit failure :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25787#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs