[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25886 [Core Tor/Tor]: Have frac_nodes_with_descriptors() take and use for_direct_connect
#25886: Have frac_nodes_with_descriptors() take and use for_direct_connect
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: neel
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-bridge-client, tor-guard, | Actual Points:
bootstrap |
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:11 neel]:
> I have made the changes in a new GitHub PR:
https://github.com/torproject/tor/pull/145
>
> This sets `f_guard` to 1.0 on bridges by checking if `UseBridges` is set
and if the original `f_guard` is greater than 0 in
`compute_frac_paths_available()`. I do understand that this may not be a
perfect solution, and may also be rejected, but it is an alternative (that
I thought of) to putting a ugly hack in `frac_nodes_with_descriptors()`
that dgoulet had mentioned.
We can't check if f_guard is non-zero, because most bridges don't have the
guard flag.
> I suggest we make f_guard = 1.0 in compute_frac_paths_available() if we
are using bridges, and have at least one bridge with ~~the preferred~~ a
full descriptor.
Instead, we need to check the number of bridges with full descriptors.
There is an existing function in bridges.h that does this check.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25886#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs