Re: [tor-bugs] #23561 [Applications/Tor Browser]: Fix nsis builds for Windows 64

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23561: Fix nsis builds for Windows 64
-------------------------------------------+-------------------------------
 Reporter:  boklm                          |          Owner:  tbb-team
     Type:  task                           |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 In `projects/nsis/build` there is a line `[% IF c("var/windows") %]`, but
 this `IF` is always true as we only build `nsis` for Windows. So I think
 the `IF` can be removed.

 Otherwise this commit looks good to me. I have started builds on 2
 machines to see if I get the same result.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23561#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs