[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26251 [Applications/Tor Browser]: Adapt macOS snowflake compilation to new toolchain
#26251: Adapt macOS snowflake compilation to new toolchain
--------------------------------------+-----------------------------------
Reporter: gk | Owner: tbb-team, sukhbir
Type: task | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+-----------------------------------
Changes (by sukhbir):
* status: needs_revision => needs_review
Comment:
For review:
https://github.com/azadi/tor-browser-build-1/tree/bug-26073-rev1
I removed `-mlinker-version=136` but the other stuff seems to be relevant.
{{{
$ git diff tor/maint-7.5...tor/master -- projects/firefox/mozconfig-osx-
x86_64
-FLAGS="-target x86_64-apple-darwin10 -mlinker-version=136 -B
$CROSS_CCTOOLS_PATH/bin -isysroot $CROSS_SYSROOT $HARDENING_FLAGS"
+FLAGS="-target x86_64-apple-darwin11 -B $CROSS_CCTOOLS_PATH/bin -isysroot
$CROSS_SYSROOT $HARDENING_FLAGS"
-export TOOLCHAIN_PREFIX=$CROSS_CCTOOLS_PATH/bin/x86_64-apple-darwin10-
-#TODO: bug 1184202 - would be nice if these could be detected with
TOOLCHAIN_PREFIX automatically
-export AR=${TOOLCHAIN_PREFIX}ar
-export RANLIB=${TOOLCHAIN_PREFIX}ranlib
-export STRIP=${TOOLCHAIN_PREFIX}strip
-export OTOOL=${TOOLCHAIN_PREFIX}otool
+export BINDGEN_CFLAGS="$FLAGS"
+export TOOLCHAIN_PREFIX=$CROSS_CCTOOLS_PATH/bin/x86_64-apple-darwin11-
}}}
I tested with the same setup as in #comment:4. As for as `gclient`, I
didn't need to do that since I did an in-place of the patch. (We will end
up with the same thing since I replaced the linker line with the clang
flag, so I didn't bother.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26251#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs