[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh



#26455: use correct CARGO_HOME in test_rust.sh
----------------------------------------------+----------------------------
 Reporter:  catalyst                          |          Owner:  catalyst
     Type:  defect                            |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.3.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:  isis                              |        Sponsor:
----------------------------------------------+----------------------------

Comment (by chelseakomlo):

 Replying to [comment:3 catalyst]:
 > Replying to [comment:2 chelseakomlo]:
 > > Good catch. We also set CARGO_HOME in `Makefile.in` so this should
 likely be updated as well?
 > Maybe not in a backported patch? I think the `cargo build` invocations
 happen to work by accident right now because they `cd` into the directory
 that contains the (autoconf-generated) `.cargo` directory in the build
 tree.
 >
 > I think it's probably better to clean up the other build instances of
 this problem on a separate ticket, because it's fortuitously working right
 now.

 It is good to keep like commits together, so if the complexity of
 backporting is too much to do in this patch, please make sure this is
 fixed in a future ticket and the ticket number noted here so we can track
 it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26455#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs