[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30615 [Core Tor/Tor]: Factor random_uniform_01 into nondeterministic and deterministic parts, and automatically test the deterministic part

#30615: Factor random_uniform_01 into nondeterministic and deterministic parts, and
automatically test the deterministic part
---------------------------------------------+-----------------------------
 Reporter:  riastradh                        |          Owner:  (none)
     Type:  enhancement                      |         Status:
                                             |  needs_revision
 Priority:  Low                              |      Milestone:  Tor:
                                             |  0.4.2.x-final
Component:  Core Tor/Tor                     |        Version:  Tor:
                                             |  0.4.1.1-alpha
 Severity:  Minor                            |     Resolution:
 Keywords:  tor-test, 041-deferred-20190530  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:  asn                              |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Can we have some more comments on what the test actually does, in
 particular what is this supposed to do in the loop:
 `        double y = sample_uniform_01(e, hi ^ (hihi << 31), lo ^ lolo);`

 Thanks!

 I also opened a PR so that the CI runs:
 https://github.com/torproject/tor/pull/1069

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30615#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs