[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30733 [Core Tor/sbws]: sbws does not detect changes in descriptor bandwidth values

#30733: sbws does not detect changes in descriptor bandwidth values
-----------------------------------+-----------------------------------
 Reporter:  starlight              |          Owner:  juga
     Type:  defect                 |         Status:  needs_revision
 Priority:  Very High              |      Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws          |        Version:  sbws: 1.1.0
 Severity:  Critical               |     Resolution:
 Keywords:  sbws-majority-blocker  |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+-----------------------------------

Comment (by juga):

 Replying to [comment:21 teor]:
 > Replying to [comment:18 juga]:
 > > Replying to [comment:14 juga]:
 > > [..]
 > > > If the descriptors bandwidth change, cool, it worked and i'll create
 the PR. If not, then i'll comment it and try to figure out what else is
 wrong.
 > >
 > > PR: https://github.com/torproject/sbws/pull/358
 > >
 > > I'm not sure whether i should change sbws bugfix version now instead
 of waiting for more bugfixes and whether i should have change
 > > the one in the longclaw's sbws, even if not released yet.
 >
 > In tor, we call development versions "alpha-dev", and include the commit
 hash in the version.
 > Let's do the same thing with sbws?
 > So for example, longclaw should now be 1.1.1-alpha-dev.

 Right now sbws is 1.1.1-dev0, since you say that it should include commit
 hash, should it be 1.1.1-alpha-dev-commithash?

 > See #30899 for a ticket, it is not urgent or important.

 In this case where i also changed the longclaw's sbws, should not i add 1
 more commit to this PR to change the version rather than doing so in a
 different ticket?. And then change also the version in longclaw's sbws to
 the same in this PR?.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs