[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central
#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--------------------------------------+--------------------------------
Reporter: acat | Owner: acat
Type: task | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam202006R | Actual Points: 14
Parent ID: #33661 | Points:
Reviewer: sysrqb, gk | Sponsor: Sponsor58-must
--------------------------------------+--------------------------------
Comment (by gk):
Replying to [comment:1 acat]:
> Rebased patches for review in https://github.com/acatarineu/tor-
browser/commits/33533.
>
> Some changes to torbutton and tor-launcher were needed:
https://github.com/acatarineu/torbutton/commit/33533 and
https://github.com/acatarineu/tor-launcher/commit/33533
>
> I used commits `7d21cd26ee65..6046d1d58280` from `tor-
browser-68.5.0esr-9.5-1`.
>
> Similarly to #30429, I put the commits/patches in different categories.
For some of them I added comments, which I hope will make reviewing
slightly easier.
>
> Regarding mobile patches, most of them have empty intersection with the
files that are currently in central (all of [mobile-gone], unless I missed
any). I only picked the mobile patches in [mobile-picked], most of them
just partially as some of the files are not in central anymore. I guess
the parts that could not be applied will have to be ported to Fenix.
>
> == [mobile-gone]
>
>
> c2da27fca068 Revert "Bug 1603270 - Add telemetry for
FirefoxPromoBannerRow user actions. r=..
> eb88d8eea02d Bug #32405: Crash immediately after bootstrap on Android
> 517624ea7f34 Bug 26529 - Prompt before opening external app
I opened #34378 for that.
> 9dab64fe2f20 Bug 31144 - Do not switching apps from CustomTabs without
consent
> c2cc5044c4ff Bug 31720: Enable website suggestions in address bar
> e661977d1bb5 Bug 1568521 Tracking protection doorhanger's Enable/Disable
states don't work ..
> a1d645909b33 Load torbutton in BrowserApp.startup on Android
> 3e871c620796 Bug 30573 - Sanitize old tabs and wait for tor before
opening new tabs
> 83137febd5bb Bug 31058: Remove Linus' default bridges
> 136bd95b705e Bug 24920 - Only create Private tabs if
browser.privatebrowsing.autostart is t..
> 75e9943e8ec9 Continue using non-adaptive icons and don't allow clear-
text traffic
> a8bcc8eb823e Bug 29238 - Prevent crash on Android after update
> 5a270452946c Bug 26690: Port padlock states for .onion services to
mobile
> [Part of this is probably in
mobile/android/modules/geckoview/GeckoViewProgress.jsm, but I
> guess this would be more like porting rather than cherry-picking
patch.]
Yep. I opened #34377 for that.
> d479cc5c77e9 Bug 28329 - Part 4. Add new Tor Bootstrapping and
configuration screens
> 7b18ef3cccbd Bug 28329 - Part 1. Add new Tor resources
> 2cd5f4f5b512 Bug 25696 - Implement alpha onboarding for Tor Browser for
Android
> 888a81d2198d Bug 27016 - Create proxy connection during image download
> 16345563997f Orfox: hook up default panic trigger to "quit and clear"
> a4f9c85167c1 Orfox: quit button added
> 5e0596ff3e30 Orfox: disable screenshots and prevent page from being in
"recent apps"
> 37c77b37cdeb Bug 25741 - TBA: Adjust the User Agent String so it doesn't
leak Android version
> 0e9127b09627 Bug 25741 - TBA: top sites changed, used bookmarks icon
temporarily.
> 06e93e8c45c7 Bug 25741 - TBA: Always Quit, do not restore the last
session
> 1f103a7c4166 Bug 25741 - TBA: Disable all data reporting by default
> b1349fb511c2 Bug 25741 - TBA: Clear state when the app exits, by default
> 9a6409fa58fb Bug 25741 - TBA: Do not import bookmarks and history from
native browser by de..
> 8b7ae6bcbd5c Bug 25741 - TBA: Do not save browsing history by default
> 81e402b80cc3 Bug 25741 - TBA: Disable QR Code reader by default
> 0f40171a057b Bug 25741 - TBA: Disable the microphone by default
> 268f04897c90 Bug 25741 - TBA: Disable telemetry and experiments
> 3729f4263efe Bug 25741 - TBA: Remove sync option from preferences
> dda2781bf72e Bug 25741 - TBA: Do not register Stumbler listener at start
up
> 4c70c3e1546b Bug 25741 - TBA: Exclude unwanted Stumbler tests
> 66d133b41794 Bug 28640 - Try showing the homepage after the Distribution
loads
> 94b9527157ed Bug 28640 - Reload distribution preferences on update
> 03b1e4c88e3a Revert "Bug 1570878 - Add sign-in buttons to onboarding.
r=petru a=RyanVM"
> c895b8c77c0d Revert "Bug 1576170 - Onboarding Sign up strings. r=flod
a=RyanVM"
> d6165a9a6b36 Revert "Bug 1585132 - Fix lint failures from sign up button
patches. r=petru, ..
> 54ab76fb79f6 Revert "Bug 1570880 - Added Sign in buttons in
Awesomescreen. r=petru a=RyanVM"
> 970ebbc553ab Revert "Bug 1570878 - Update fenenc onboarding content.
r=petru a=RyanVM"
> feed391bf77a Revert "Bug 1586205 - Change LP variables to fallback to
same nonLP defaults. ..
> 104889f3a5ec Revert "Bug 1587631 - Add FxA entrypoint option for panel
configurations. r=pe..
> 5c35e3f85a0f Revert "Bug 1603275 - Add a new FirefoxPromoBannerRow for
the awesomescreen. r..
> 7d21cd26ee65 Revert "Bug 1603275 - Restore "Sign up" button shadow.
r=VladBaicu, a=RyanVM"
>
Not picking all those patches looks good to me.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33533#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs