Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-sign, tbb-maint,                 |  Actual Points:
  GeorgKoppen202005, TorBrowserTeam202006R       |
Parent ID:                                       |         Points:
 Reviewer:  sysrqb                               |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * status:  needs_review => needs_revision


Comment:

 Can we print the error message for only non-osx64? Printing 35+ non-match
 messages seems like unnecessary noise.

 {{{
 +    if ! [ "$sha256_txt" = "$(sha256sum "$f")" ]
      then
        echo "$f does not have the SHA-256 sum of the unsigned MAR file!"
 -      BADSIGNED_MARS=`expr $BADSIGNED_MARS + 1`
 +      not_reproduced_mars=$((not_reproduced_mars + 1))
 +      case "$f" in
 +        *osx64*)
 +          not_reproduced_mars_expected=$((not_reproduced_mars_expected +
 1))
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32895#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs