[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33420 [Metrics/Onionperf]: Add CBT events to Onionperf result files
#33420: Add CBT events to Onionperf result files
-------------------------------------------------+-------------------------
Reporter: acute | Owner: karsten
Type: enhancement | Status:
| needs_information
Priority: Medium | Milestone:
Component: Metrics/Onionperf | Version:
Severity: Normal | Resolution:
Keywords: metrics-team-roadmap-2020, metrics- | Actual Points: 0.3
team-roadmap-2020-june |
Parent ID: #33321 | Points: 2.0
Reviewer: | Sponsor:
| Sponsor59-must
-------------------------------------------------+-------------------------
Comment (by karsten):
I'm moving mikeperry's `DROPTIMEOUTS` feature branch from #33399 here,
because this ticket is about circuit build timeouts whereas #33399 is
about static guards.
It's possible that we'll want to do both (use static guards ''and'' drop
build timeouts when dropping guards), but the development effort can
happen in separate tickets.
mikeperry wrote:
> https://github.com/mikeperry-tor/tor/commits/droptimeouts provides this
functionality.
>
> https://github.com/mikeperry-tor/torspec/commits/droptimeouts provides
the spec.
>
> LMK if this looks good and I'll open a sub-ticket for network-team to
merge.
mikeperry added a bit later:
> I just noticed that DROPGUARDS has a call to or_state_mark_dirty()
buried deep in its callpath. I did not do this for DROPTIMEOUTS, but it is
easy enough to throw a call in there.
>
> This should only matter if there is a risk of restarting or SIGHUPing
the tor process right after DROPTIMEOUTS. The CBT code will mark the state
file dirty again as soon as it records 10 circuit build times.
I'll also add that we'll need a Stem patch in order to send the
`DROPTIMEOUTS` command. We can add that later after adding the Tor patch
and after being sure that it does what we need.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33420#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs