[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28396 [Applications/rbm]: Temporary gpg signature verification scripts are not removed
#28396: Temporary gpg signature verification scripts are not removed
-----------------------------------+------------------------------
Reporter: boklm | Owner: tbb-team
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/rbm | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam202006R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------------+------------------------------
Changes (by boklm):
* keywords: => TorBrowserTeam202006R
* status: assigned => needs_review
Comment:
There is a patch fixing that in branch `bug_28396_v2`:
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_28396_v2&id=30188a4ffe947fb728c86600b793df775cc171e7
The patch is fixing that by creating all temporary files inside
`rbm_tmp_dir` instead of `tmp_dir`, which is removed automatically when
rbm exits.
While doing that I also noticed an issue with `urlget`, which used
`tmp_dir`, causing scripts using `urlget` to depend on the value of
`tmp_dir`. For example this caused the filename of `firefox-langpacks` to
change when we move the `tor-browser-build` directory. `urlget` is also
used in `projects/common/fetch-gradle-dependencies` so we have the same
issue with projects using this script. With this patch, the `tor-browser`
filename is not changing anymore when we move the `tor-browser-build`
directory.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28396#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs