Re: [tor-bugs] #2557 [BridgeDB]: BridgeDB fails with a traceback when turning off a distributor

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#2557: BridgeDB fails with a traceback when turning off a distributor
-------------------------+--------------------------------------------------
    Reporter:  karsten   |       Owner:  nickm   
        Type:  defect    |      Status:  reopened
    Priority:  normal    |   Milestone:          
   Component:  BridgeDB  |     Version:          
  Resolution:            |    Keywords:          
      Parent:            |      Points:          
Actualpoints:            |  
-------------------------+--------------------------------------------------
Changes (by karsten):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Patch looks good.  Two minor comments:

  - I'm not 100% certain about the new semantics of
 `insertBridgeAndGetRing()`.  What's a "validated ring"?  And should the
 comment mention that we're returning `defaultPool` if the new ring (or the
 ring in the database?) is not contained in `validRings`?

  - I wonder why the changes in `Tests.py` work at all.  If there are only
 `ring1`, `ring2`, and `ring3` and we insert a bridge into `ring10`, how
 does it end up in `ring1` and not in `unallocated`?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2557#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs