[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2611 [Vidalia]: Remove OpenSSL dependency
#2611: Remove OpenSSL dependency
-------------------------+--------------------------------------------------
Reporter: chiiph | Owner: chiiph
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: Vidalia | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by chiiph):
Replying to [comment:6 edmanm]:
> For some reason your Zlib-related patch includes the patch for some
other ticket that was about disabling the dirport for bridges. If you cut
that out, feel free to commit the rest of the Zlib patch.
Ohj, it keeps happening, sorry.
I'll commit the fixed patch for zlib.
>
> As for the new OpenSSL-related patch, you shouldn't be deleting
`FindOpenSSL.cmake` and the related `INSTALL` reference for
`-DOPENSSL_LIBRARY_DIR=/path/to/openssl` entirely. The Windows installer
files still need the `OPENSSL_LIBRARY_DIR` macro in order to find the
OpenSSL files that get included in the installer. You just want to cut out
the non-Windows stuff. The `TorSslSocket` class removal stuff looks good,
though.
Right. The INSTALL reference for OPENSSL_LIBRARY_DIR should change to
something like:
"Specify the location of OpenSSL's libraries when building on Windows."
I'll attach the updated patch in a bit.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2611#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs