[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2511 [Tor Bridge]: Tor will use an unconfigured bridge if it was a configured bridge last time you ran Tor
#2511: Tor will use an unconfigured bridge if it was a configured bridge last time
you ran Tor
------------------------+---------------------------------------------------
Reporter: arma | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Bridge | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by arma):
Replying to [comment:13 nickm]:
> It's still icky
I'd be in favor of an 0.2.3.x-or-later refactoring of how we decide which
relays go in which local relay lists. I don't think it will be easy, but
that's all the more reason to look at it.
> I'm having a quick look through things that use the was_router_added_t
values to make sure it's okay to add a new one. All I can see is the
WRA_WAS* functinos in routerlist.h. Do we want to add
ROUTER_WAS_NOT_WANTED to one of these?
I think we don't. It wasn't accepted, it wasn't rejected-by-the-authority,
and it wasn't outdated. I guess we could call it OUTDATED if we want.
Nothing in the code that we do for OUTDATED descs (all of two things) is
something we want to do for this situation, but nothing we do is harmful
either. Those functions seem kind of fuzzy anyway in terms of what they
mean. Perhaps they should be included in the hypothetical future refactor
above. :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2511#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs