[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2799 [Tor Hidden Services]: Use cbt results when deciding to launch parallel introduction circuit?

#2799: Use cbt results when deciding to launch parallel introduction circuit?
---------------------------------+------------------------------------------
 Reporter:  nickm                |          Owner:                    
     Type:  defect               |         Status:  needs_review      
 Priority:  normal               |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by mikeperry):

 Looks ok. But should we be calling gettimeofday in all these functions as
 opposed to passing the value in? I suppose they aren't called more than
 once per second in all cases anyways, right?

 Also, re your previous comments, yes we ensure the timeout_ms is never
 below 500, and kick out a warn if it is. See CBT_MIN_TIMEOUT_MIN_VALUE. It
 is also possible to set a consensus parameter to override this define.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2799#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs