Re: [tor-bugs] #3594 [Tor Bridge]: Add support for SOCKS parameters in Bridge and {Client, Server}TransportPlugin lines

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3594: Add support for SOCKS parameters in Bridge and
{Client,Server}TransportPlugin lines
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:  #4685             
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Reviewing...

   * I think the names for tor_escape_string and string_is_key_value should
 really have something to say they're only for this particular use (socks
 argument parsing/encoding).
     * It makes me sad that we are proliferating ways to escape and
 unescape stuff.
     * Can string_is_key_value ever be given escaped srings?
     * Is it really invalid to have a "K=" to indicate that K is set to the
 empty string?
     * Will the escape function ever get called with escape_char != '\\' ?
   * tor_char_is_in_set could be replaced with strchr

 Other than that, looks mergeable in 0.2.4.x.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3594#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs