[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5352 [Vidalia]: option to stop telling me firefox is going to start

#5352: option to stop telling me firefox is going to start
-------------------------+--------------------------------------------------
 Reporter:  phobos       |          Owner:  sirop               
     Type:  enhancement  |         Status:  needs_revision      
 Priority:  normal       |      Milestone:                      
Component:  Vidalia      |        Version:  Vidalia: 0.3.1-alpha
 Keywords:  plugin, tbb  |         Parent:                      
   Points:               |   Actualpoints:                      
-------------------------+--------------------------------------------------
Changes (by chiiph):

  * status:  needs_review => needs_revision


Comment:

 Overall looks good. A couple of notes:
 - If I start TBB with DontShowTrayBox=false, then change it to true and I
 restart tor, I will still see the notification.
 - You have changed the way the settings behave, which is another issue,
 not this one.
 - It's Tor, not TOR.
 - There are a couple of bad indentations (see the first if in that patch,
 for example).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5352#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs