[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2733 [Vidalia]: Option to filter message log output by search term
#2733: Option to filter message log output by search term
-------------------------+--------------------------------------------------
Reporter: chiiph | Owner: sebb
Type: enhancement | Status: needs_revision
Priority: minor | Milestone:
Component: Vidalia | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Changes (by chiiph):
* status: needs_review => needs_revision
Comment:
A couple of comments:
* When deleting _expressionTree, you should check that it was created:
{{{
if(_expressionTree)
delete _expressionTree;
}}}
The same applies to _logFilter, _left, _right.
* There is no need to do #include "TorControl.h" if you are not using it.
* LogFilterSearchTerm has public members, they should be private.
* This seems an unnecessary variable creation:
{{{
+ ExpTree * left = tree.pop();
+ ExpTree * right = tree.pop();
+ ExpTree * node = new ExpTree(s);
+ node->_left = left;
+ node->_right = right;
}}}
* Coding style things:
- You should leave a space on the left of {
- In method's implementation, the return type should be on a different
line than the signature. Check the HACKING doc for more info on that.
- If the if statement has only one line, remove the {}, unless they are
there for consistency with the rest of the if/then/else.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2733#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs