[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4875 [Tor Client]: router_new_address_suggestion is not IPv6 aware

#4875: router_new_address_suggestion is not IPv6 aware
------------------------+---------------------------------------------------
 Reporter:  dcf         |          Owner:  ln5                
     Type:  defect      |         Status:  needs_review       
 Priority:  minor       |      Milestone:  Tor: 0.2.3.x-final 
Component:  Tor Client  |        Version:  Tor: 0.2.3.10-alpha
 Keywords:  ipv6        |         Parent:  #3563              
   Points:              |   Actualpoints:                     
------------------------+---------------------------------------------------

Comment(by nickm):

 re the patch contents:

   * Let's just always use strlcpy, not strcpy.  OpenBSD spews warnings
 when you use strcpy, and the performance/convenience advantage just isn't
 worth it.
   * I don't like {AF_UNSPEC,{0}} as a literal initializer.  If we want to
 have something like that, it ought to be a macro in address.h , so we use
 it everywhere and change it in one place only if the representation of
 tor_addr_t changes.
   * It needs a real commit message and a changes file.
   * I think that cherry-picking it back onto something pre-#4561 makes
 sense : when I tried "git cherry-pick 1ff25a3e", there was only one
 (trivial) conflict.
   * Can you tell me a little about the "XXX ipv6" instances?  It looks
 like part of this patch makes parts of the code work with IPv6, but other
 parts of the patch assume that everything is still IPv4?  Or do I
 understand wrong?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4875#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs