[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5472 [Stem]: Stem version parser matches git hash too

#5472: Stem version parser matches git hash too
--------------------+-------------------------------------------------------
 Reporter:  neena   |          Owner:  neena         
     Type:  defect  |         Status:  needs_revision
 Priority:  normal  |      Milestone:                
Component:  Stem    |        Version:                
 Keywords:          |         Parent:                
   Points:          |   Actualpoints:                
--------------------+-------------------------------------------------------

Comment(by atagar):

 > Alternatively, we could use another variable in Version to store
 anything after the first space. This will usually be (git-$HASH).

 Oops, forgot to comment on this. That is tempting since the git commit id
 could be interesting information to the caller. However, it isn't in the
 spec and I'd rather only include information that we can rely on being
 there. This information might easily disappear or change in upcoming tor
 versions.

 Might be handy to add in the future, but for now lets leave it out.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5472#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs