Re: [tor-bugs] #5472 [Stem]: Stem version parser matches git hash too

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#5472: Stem version parser matches git hash too
--------------------+-------------------------------------------------------
 Reporter:  neena   |          Owner:  neena       
     Type:  defect  |         Status:  needs_review
 Priority:  normal  |      Milestone:              
Component:  Stem    |        Version:              
 Keywords:          |         Parent:              
   Points:          |   Actualpoints:              
--------------------+-------------------------------------------------------
Changes (by neena):

  * status:  needs_revision => needs_review


Comment:

 Replying to [comment:7 atagar]:
 > The plain mock function is simpler, and keeping code simple is a very
 good thing. You're right that if we add several more tests later then your
 lambda function will be preferable. But lets not optimize for that until
 it happens.

 Alright.
 In that case, I'm going to let TOR_VERSION_OUTPUT be a global var, since
 we can change that later too. It looks neater than returning a multiline
 triple quoted string anyway.

 I've pushed the latest to my branch. Is there anything else that needs
 changing?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5472#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs